Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Facebook CTL tests as pending when network is too slow #1361

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Aug 21, 2022

Occasionally the network will be too slow on the GitHub CI runner for
any Facebook requests to be made within 15 seconds. When that happens,
let's mark the tests as skipped (pending) instead of failing (or
passing).

Reviewer: @jonathanKingston

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Occasionally the network will be too slow on the GitHub CI runner for
any Facebook requests to be made within 15 seconds. When that happens,
let's mark the tests as skipped (pending) instead of failing (or
passing).
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still have an issue tracking this, we should keep it open despite this mitigation.

Thanks!

@jonathanKingston jonathanKingston merged commit e84d026 into duckduckgo:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants