-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tab to serialize to storage #1363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanKingston
force-pushed
the
jkt/refactor-tab
branch
10 times, most recently
from
August 25, 2022 23:21
702776b
to
feb47f4
Compare
12 tasks
jonathanKingston
force-pushed
the
jkt/refactor-tab
branch
4 times, most recently
from
September 2, 2022 21:08
a466e91
to
4cee84d
Compare
jonathanKingston
force-pushed
the
jkt/refactor-tab
branch
from
September 8, 2022 11:36
ecc0e20
to
8127927
Compare
shakyShane
requested changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments :)
shakyShane
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
jonathanKingston
changed the title
Jkt/refactor tab
Refactor tab to serialize to storage
Sep 9, 2022
jonathanKingston
force-pushed
the
jkt/refactor-tab
branch
2 times, most recently
from
September 22, 2022 23:24
318d36b
to
fed8c7c
Compare
…hange the restore methods to take an id. Restore the tab properly on startup.
jonathanKingston
force-pushed
the
jkt/refactor-tab
branch
from
September 27, 2022 19:19
fed8c7c
to
a008cf1
Compare
jonathanKingston
force-pushed
the
jkt/refactor-tab
branch
from
September 27, 2022 19:22
a008cf1
to
4aae721
Compare
shakyShane
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Description:
Create a new class to manage the state of tabs and sites.
These need writing to session storage to allow us to restore their state after the service worker is reinitialized.
Uses getters and setters in to store into the new class from tab and site.
Changing the tab and site shape to have getters and setters will break the consumers of the current tab serialization also (we serialize over message passing to different contexts which turns classes into plain objects).
So additionally we will need to manually serialize into this plain object format for sending over to different contexts; this will allow autofill, content-scope-scripts and the dashboard to retain their current usage of tab and site data.
https://app.asana.com/0/0/1202914947727988/f
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: