Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reporting of MV2 to MV3 extension. #1371

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Aug 25, 2022

Reviewer:

Description:

Reuse onBeforeRequest reporting flow for MV3, this means we need to retain feature parity.

It was deemed that the reporting APIs provided by MV3 were not suitable for our needs due to the cadence they come in.

See: https://app.asana.com/0/0/1202842358783023/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston jonathanKingston marked this pull request as draft August 25, 2022 00:15
Reuse onBeforeRequest reporting flow for MV3, this means we need to retain feature parity.

It was deemed that the reporting APIs provided by MV3 were not suitable for our needs due to the cadence they come in.
@jonathanKingston jonathanKingston marked this pull request as ready for review August 31, 2022 13:26
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jonathanKingston jonathanKingston merged commit 3bf36d5 into develop Sep 1, 2022
@jonathanKingston jonathanKingston deleted the jkt/mv3-enable-request-reports branch September 1, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants