Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove migrate company data code #1372

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Remove migrate company data code #1372

merged 1 commit into from
Aug 25, 2022

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Aug 25, 2022 •
edited

Reviewer:

Description:

This data entity migration code is from 2019, I think we can safely remove.

https://app.asana.com/0/312629933896096/1202842358783024/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jdorweiler jdorweiler merged commit ea968dc into develop Aug 25, 2022
@jonathanKingston jonathanKingston deleted the jkt/remove-migrate branch August 25, 2022 13:44
jonathanKingston added a commit that referenced this pull request Sep 1, 2022
@jonathanKingston
Remove migrate company data code (#1372)
996f3f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdorweiler jdorweiler jdorweiler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanKingston @jdorweiler