Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some type checking issues with referrer trimming #1385

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Sep 2, 2022

The argumentsObject and referrer trimming code were failing TypeScript
linting, so linting was disabled for those files. Let's fix the
problems and enable TypeScript linting again for them.

Reviewer: @jonathanKingston

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

The argumentsObject and referrer trimming code were failing TypeScript
linting, so linting was disabled for those files. Let's fix the
problems and enable TypeScript linting again for them.
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real issues just two discussion points 👍🏻

Edit: one discussion point because neither are side are great and I see why TS was sad :).

@jonathanKingston jonathanKingston merged commit bc0bf26 into duckduckgo:develop Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants