Fix Facebook videos if protocol isn't specified in data-href #1411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded Facebook videos are created by having a div element in the page that has (amongst other attributes) a data-href attribute that specifies the video's URL. The Facebook SDK then uses that to create the video iframe. Our "surrogate script" does the same.
It turns out that when the protocol prefix of that URL isn't specified (e.g. the URL starts '//'), then the SDK and our surrogate script need to take care to add the correct protocol to the URL (e.g. 'http:' or 'https:') based on the window location. Otherwise, the video fails to load.
Reviewer: @ladamski
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: