Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy surrogate file #1434

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Remove legacy surrogate file #1434

merged 1 commit into from
Oct 5, 2022

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Oct 5, 2022 •
edited

Reviewer: @kzar

Description:

This file seems totally unused; the code is instead done through privacy-grade. I think this is safe to remove.

https://app.asana.com/0/312629933896096/1203103347873067/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

kzar
kzar approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

@jonathanKingston jonathanKingston merged commit 06dcf26 into duckduckgo:develop Oct 5, 2022
@jonathanKingston jonathanKingston deleted the jkt/remove-surrogate-file branch October 5, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzar kzar kzar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanKingston @kzar