Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CTL "surrogate scripts" that now live in tracker-surrogates repo #1435

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Oct 5, 2022

We have recently moved[1] the Click to Load "surrogate scripts" to the tracker-surrogates[2] repository. Let's complete the work by removing the old copy of those files from this repository.

1 - duckduckgo/tracker-surrogates@54933a3
2 - https://github.com/duckduckgo/tracker-surrogates

Reviewer: @jonathanKingston
CC: @ladamski

Steps to test this PR:

  1. Ensure CTL integration tests still pass.
  2. Install extension.
  3. Open developer tools and switch to network panel for a new tab.
  4. Navigate to https://privacy-test-pages.glitch.me/privacy-protections/click-to-load/
  5. Ensure the Facebook SDK request is redirected to the surrogate script successfully.
  6. Ensure the test page works OK.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

We have recently moved[1] the Click to Load "surrogate scripts" to the
tracker-surrogates[2] repository. Let's complete the work by removing
the old copy of those files from this repository.

1 - duckduckgo/tracker-surrogates@54933a3
2 - https://github.com/duckduckgo/tracker-surrogates
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzar kzar merged commit a692770 into duckduckgo:develop Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants