Reduce the number of files ignored by tsc linting #1452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript linter tsc is set to ignore some modules, since there
are some linting errors in those files. The problem with that (other
than missing out on the benefits of type checking), is that when one
of the ignored modules is later imported by a non-ignored module, the
previously-ignored module will start being checked again. This results
in a kind of trap where importing the wrong module suddenly results in
dozens of linting errors!
Let's improve the situation by reducing the number of ignored
modules.
One interesting linting error I hit was:
It turned out, that was caused by modules that used CommonJS exports,
but that started with an ES import. To fix those errors, I switched
back to CommonJS imports in those situations. We should obviously
switch to ES modules generally in the future.
Reviewer: @jonathanKingston
Description:
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: