Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message getShareFeedbackLink while message handler is not ready #1472

Merged

Conversation

franfaccin
Copy link
Contributor

Reviewer:

Description:

We were requesting the Feedback Form url through a message getShareFeedbackLink, but since this message handler is not ready yet, it was throwing errors in the background.

Steps to test this PR:

Build steps: https://github.com/duckduckgo/duckduckgo-privacy-extension/blob/develop/CONTRIBUTING.md#building-the-extension

  1. Access https://privacy-test-pages.glitch.me/privacy-protections/youtube-click-to-load/2.
  2. Inspect background page
  3. It should not throw an error Unrecognized message to background: {messageType: 'getShareFeedbackLink', options: ''}

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@franfaccin franfaccin self-assigned this Oct 26, 2022
@jonathanKingston jonathanKingston merged commit 137b000 into duckduckgo:develop Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants