Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup issue moving to ESM module #1473

Merged

Conversation

jonathanKingston
Copy link
Collaborator

Reviewer:

Description:

#1471 this fixed the other branch in the same way. As I understand it you were seeing CJS and ESM fighting for being the correct instance.

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston jonathanKingston changed the title Fix startup issue Fix startup issue moving to ESM module Oct 26, 2022
@jonathanKingston jonathanKingston merged commit 78b879a into duckduckgo:develop Oct 26, 2022
@jonathanKingston jonathanKingston deleted the jkt/fix-startup-import branch October 26, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants