Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout, cache and setup-node versions to v3. Remove tests on… #1476

Conversation

jonathanKingston
Copy link
Collaborator

… push and instead run on PR only

Reviewer:

Description:

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston jonathanKingston marked this pull request as ready for review October 26, 2022 17:03
@jonathanKingston jonathanKingston force-pushed the jkt/update-automation-node branch 26 times, most recently from 870dd8c to 75900e7 Compare October 27, 2022 01:47
Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a potentially redundant npm install and a question about the actions update frequency.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
@jonathanKingston jonathanKingston merged commit f03944e into duckduckgo:develop Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants