Avoid failing YouTube CTL tests when network is slow #1487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YouTube Click to Load integration tests check a bunch of things, including that interacting with the YouTube Iframe API works correctly. Unfortunately, these tests fail sometimes when run inside a GitHub action since the test runner is too slow to load (or even request) the Iframe API script. When the script has failed to be requested in time, let's mark the test as pending (aka skipped) instead of declaring a failure.
1 - https://developers.google.com/youtube/iframe_api_reference
Reviewer: @jonathanKingston
Automated tests:
Reviewer Checklist:
PR Author Checklist: