Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing YouTube CTL tests when network is slow #1487

Merged

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Oct 28, 2022

The YouTube Click to Load integration tests check a bunch of things, including that interacting with the YouTube Iframe API works correctly. Unfortunately, these tests fail sometimes when run inside a GitHub action since the test runner is too slow to load (or even request) the Iframe API script. When the script has failed to be requested in time, let's mark the test as pending (aka skipped) instead of declaring a failure.

1 - https://developers.google.com/youtube/iframe_api_reference

Reviewer: @jonathanKingston

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

The YouTube Click to Load integration tests check a bunch of things,
including that interacting with the YouTube Iframe API works
correctly. Unfortunately, these tests fail sometimes when run inside a
GitHub action since the test runner is too slow to load (or even
request) the Iframe API script. When the script has failed to be
requested in time, let's mark the test as pending (aka skipped)
instead of declaring a failure.

1 - https://developers.google.com/youtube/iframe_api_reference
@kzar kzar marked this pull request as ready for review October 28, 2022 08:48
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, it's better than disabling entirely.

Thanks for looking into this, I was going to spend some time on it next so you saved me :)

@jonathanKingston jonathanKingston merged commit b5a44e9 into duckduckgo:develop Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants