Avoid blocking ServiceWorker initiated requests for Chrome MV3 #1544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already avoid blocking ServiceWorker initiated requests in the MV2
extension, since each time we enabled the blocking of those we saw
major website breakage. In the future, we'd like to start blocking
those requests again, but we'll have to do so carefully.
Anyway, it's important that request blocking is consistent between MV2
and MV3 builds of the extension. So for now, let's also avoid blocking
ServiceWorker initiated requests for Chrome MV3 builds too.
Note: The way we do this, is to ignore requests with a tabId of
-1 (aka requests not associated with a tab). This could also
lead to other requests being ignored, but since that's
consistent with the MV2 code-path[1] it seems the right approach.
1 -
duckduckgo-privacy-extension/shared/js/background/before-request.es6.js
Line 85 in 92222c8
Reviewer: @jdorweiler
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: