Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate watch command #1689

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Reinstate watch command #1689

merged 1 commit into from
Feb 6, 2023

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Feb 6, 2023

Reviewer:

Description:

  • Reinstates the watch command as 'monitor' internally. No other changes needed to dev flows.
  • Externally presenting it as watch=1 and 0 still.

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Gruntfile.js Show resolved Hide resolved
Copy link
Collaborator

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonathanKingston jonathanKingston merged commit 37eba30 into develop Feb 6, 2023
@jonathanKingston jonathanKingston deleted the jkt/reinstate-watch branch February 6, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants