Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to sync open pull requests to Asana #1691

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

sammacbeth
Copy link
Collaborator

@sammacbeth sammacbeth commented Feb 7, 2023

Reviewer:

Description:

Adds a new workflow that adds and updates PR tasks in Asana.

Steps to test this PR:

Unfortunately, pull_request_target actions only start working after they get merged into the main branch, so we can't test this ahead of time.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@sammacbeth sammacbeth requested a review from kzar February 7, 2023 09:33
@sammacbeth sammacbeth merged commit 30694bb into duckduckgo:develop Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants