-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy Click to Load configuration #1710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzar
force-pushed
the
remove-legacy-ctl
branch
from
February 7, 2023 14:32
5663edf
to
ddfbf14
Compare
kzar
commented
Feb 7, 2023
kzar
commented
Feb 7, 2023
kzar
force-pushed
the
remove-legacy-ctl
branch
from
February 7, 2023 14:59
ddfbf14
to
bc18b38
Compare
sammacbeth
reviewed
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I think you've overcomplicated things with the serializable disabledClickToLoadRuleActions
. I proposed an alternative.
kzar
force-pushed
the
remove-legacy-ctl
branch
from
February 8, 2023 16:22
bc18b38
to
c578e6c
Compare
kzar
commented
Feb 8, 2023
kzar
force-pushed
the
remove-legacy-ctl
branch
from
February 8, 2023 16:26
c578e6c
to
035fbb9
Compare
kzar
force-pushed
the
remove-legacy-ctl
branch
9 times, most recently
from
February 9, 2023 11:29
c5a4e44
to
774d82c
Compare
The migration away from the legacy social_ctp_configuration.json configuration for Click to Load is complete. Let's use the new configuration for the MV2 code paths and remove all references to the legacy configuration. While at it, let's also: - Deprecate the clickToLoadClicks Object that's no longer required and remove the corresponding logic. - Remove the imgToData function that was added for Click to Load but no longer used. - Remove a now unused webNavigation.onCommitted listener that was originally needed for Click to Load. - Rewrite the Click to Load unit tests that were passing incorrectly. - Fix the Click to Load Facebook integration tests, so that they aren't marked as pending when blocking fails.
kzar
force-pushed
the
remove-legacy-ctl
branch
from
February 9, 2023 11:30
774d82c
to
4d87fcb
Compare
sammacbeth
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration away from the legacy social_ctp_configuration.json
configuration for Click to Load is complete. Let's use the new
configuration for the MV2 code paths and remove all references to the
legacy configuration.
While at it, let's also:
and remove the corresponding logic.
no longer used.
originally needed for Click to Load.
incorrectly.
aren't marked as pending when blocking fails.
Reviewer: @sammacbeth
Cc: @ladamski, @franfaccin
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: