Trigger refresh of Click to Load placeholders on request block #1738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the Click to Load placeholders were only drawn once at
the point page load completed. That had two problems:
took a long time to load fully.
blocked content was only created after page load had finished.
To fix that, let's send a message to the content-scope-script to
ensure that placeholders are refreshed each time a Click to Load
request is blocked.
Also tweak the response messages to be inline with the recent
content-scope-script changes to make response messages easier to
identify.
Unfortunately the YouTube Click to Load integration tests need to be
disabled for now, since we had to disable the "hideTrackingElement"
option for now which breaks some of the YouTube SDK integration.
Reviewer: @ladamski
CC: @franfaccin
Steps to test this PR:
These changes depends on these content-scope-scripts changes.
Open the options page, change "options.html" in the URL to "devtools-panel.html", click the tiny config icon in the top-right, select "config" in the drop-down, search for "clickToPlay" and add update the config to enable YouTube Click to Load:
Automated tests:
Reviewer Checklist:
PR Author Checklist: