-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Facebook CTL tests to Playwright #1764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammacbeth
force-pushed
the
sam/202303/fb-ctl
branch
from
March 7, 2023 12:02
af62dbe
to
280c185
Compare
sammacbeth
force-pushed
the
sam/202303/fb-ctl
branch
4 times, most recently
from
March 7, 2023 16:30
fea41a9
to
dd2220b
Compare
kzar
reviewed
Mar 9, 2023
kzar
reviewed
Mar 10, 2023
This is required so the folder exists during integration tests
sammacbeth
force-pushed
the
sam/202303/fb-ctl
branch
from
March 10, 2023 12:30
1e8b395
to
12d0900
Compare
kzar
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: