Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the unit test build step #1769

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Mar 8, 2023

Remove the buildTests script, since we can bundle the unit test files
with Browserify directly from the Makefile. In the future, we should
remove shared/content-scope-scripts entirely, but making that work
with Browserify is proving to be tricky.

Reviewer: @sammacbeth

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Remove the buildTests script, since we can bundle the unit test files
with Browserify directly from the Makefile. In the future, we should
remove shared/content-scope-scripts entirely, but making that work
with Browserify is proving to be tricky.
@kzar kzar requested a review from sammacbeth March 8, 2023 23:32
@kzar kzar merged commit 48b4025 into duckduckgo:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants