Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Click to Load YouTube settings if feature is enabled #1771

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Mar 9, 2023

The Click to Load YouTube feature has a settings in the options page,
so that the user can configure video previews. Let's start displaying
that, but only if the feature is enabled.

Reviewer: @franfaccin

Steps to test this PR:

  1. Open the options page and check the YouTube preview setting isn't visible.
  2. Enable YouTube Click to Load (change "options.html" in options page URL to "devtools-panel.html", select the tiny config icon at top left, select "config" in drop down, search for "clickToLoad" and set "Youtube" state to "enabled".
  3. Open options page again, and check the setting is visible.
  4. Test toggling the setting to ensure previews are disabled/enabled (you can use the test page here).

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

The Click to Load YouTube feature has a settings in the options page,
so that the user can configure video previews. Let's start displaying
that, but only if the feature is enabled.
@kzar kzar requested a review from franfaccin March 9, 2023 16:13
Copy link
Contributor

@franfaccin franfaccin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the build and toggled the CTL settings and the Options setting appeared and disappeared as expected. Great job making it conditional to the feature flag ✅

@kzar kzar merged commit 5941fda into duckduckgo:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants