Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source maps for development builds #1772

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Mar 9, 2023

Let's have Browserify generate source maps again for development
builds, they make debugging the code a lot easier. But let's keep them
off for production builds, since the background.js bundle grows from
~2 MB to ~5 MB when we add them.

Reviewer: @sammacbeth

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Let's have Browserify generate source maps again for development
builds, they make debugging the code a lot easier. But let's keep them
off for production builds, since the background.js bundle grows from
~2 MB to ~5 MB when we add them.
@jonathanKingston jonathanKingston merged commit dbcb0d5 into duckduckgo:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants