Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Makefile notices changes to our other repositories #1774

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Mar 10, 2023

The Makefile is set up to notice changes to the code, rebuilding as
necessary. Let's also have it watch for changes to our other
repositories (under node_modules/@duckduckgo/) and repositories that
have been combined with this one (under packages/).

Reviewer: @sammacbeth

Steps to test this PR:

  1. Run make dev browser=chrome type=dev twice.
  2. It should say "make: Nothing to be done for 'dev'."
  3. Edit a file under packages/privacy-grade or node_modules/@duckduckgo/*
  4. Run make dev browser=chrome type=dev and ensure the bundles are rebuilt.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

The Makefile is set up to notice changes to the code, rebuilding as
necessary. Let's also have it watch for changes to our other
repositories (under node_modules/@duckduckgo/) and repositories that
have been combined with this one (under packages/).
@kzar kzar requested a review from sammacbeth March 10, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants