Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output when watching for changes #1775

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Mar 10, 2023

Commands such as npm run dev-chrome call something like make watch browser=chrome type=dev under the hood. The CLI output was a little
confusing, since it wasn't clear when the initial build had
finished. Let's improve that by keeping make silent until there are
changes, and displaying a clear "Build ready - Watching for changes"
message.

Reviewer: @sammacbeth

Steps to test this PR:

  1. Run npm run dev-chrome and check the output makes sense.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Commands such as `npm run dev-chrome` call something like `make watch
browser=chrome type=dev` under the hood. The CLI output was a little
confusing, since it wasn't clear when the initial build had
finished. Let's improve that by keeping make silent until there are
changes, and displaying a clear "Build ready -  Watching for changes"
message.
@kzar kzar requested a review from sammacbeth March 10, 2023 12:24
@kzar kzar merged commit 75c6fef into duckduckgo:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants