Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Make watching for changes to packages/*/node_modules #1778

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Mar 10, 2023

It turns out that including packages/privacy-grade/node_modules caused
builds to break on macOS when some temporary Puppeteer files were
included by mistake. Let's exclude node_modules for packages/.

Reviewer: @sammacbeth

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@kzar kzar force-pushed the find-exclude-node-modules branch from c0324c4 to a562a56 Compare March 10, 2023 15:00
@kzar kzar marked this pull request as ready for review March 10, 2023 15:05
It turns out that including packages/privacy-grade/node_modules caused
builds to break on macOS when some temporary Puppeteer files were
included by mistake. Let's exclude node_modules for packages/.
@kzar kzar force-pushed the find-exclude-node-modules branch from a562a56 to 69e77dc Compare March 10, 2023 15:10
@kzar kzar changed the title Exclude node_modules from packages/ from source files Avoid Make watching for changes to packages/*/node_modules Mar 10, 2023
@kzar kzar merged commit b84d2fd into duckduckgo:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants