Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowlisting does not disable serviceworker request blocking in the same session #1952

Merged

Conversation

sammacbeth
Copy link
Collaborator

@sammacbeth sammacbeth commented May 2, 2023

Reviewer:

Description:

Fixes syncing allowlist changes to serviceworker tabs.

Steps to test this PR:

  1. go to https://privacy-test-pages.glitch.me/privacy-protections/request-blocking/
  2. disable protections
  3. run test
  4. 'serviceworker-fetch' should be allowed.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, one typo.

@sammacbeth sammacbeth force-pushed the sam/202304/sw-allowlisting branch 2 times, most recently from 6edccf7 to 77ee902 Compare May 4, 2023 18:30
@jonathanKingston jonathanKingston merged commit e7601a7 into duckduckgo:main May 22, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants