Disable local proxying for adclick attribution tests #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammacbeth
force-pushed
the
sam/ad-click-failures
branch
from
24608e7
to
96c3b7f
Compare
sammacbeth
force-pushed
the
sam/ad-click-failures
branch
from
96c3b7f
to
c3978de
Compare
jonathanKingston
approved these changes
Oct 23, 2023
sammacbeth
added a commit
that referenced
this pull request
Oct 31, 2023
This reverts commit 09b27eb.
sammacbeth
added a commit
that referenced
this pull request
Nov 20, 2023
This reverts commit 09b27eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
Disable local proxying for ad-click attribution tests, as this was causing failures on headless linux machines.