Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disable local proxying for adclick attribution tests" #2311

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "Disable local proxying for adclick attribution tests" #2311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions integration-test/click-attribution.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { test, expect } from './helpers/playwrightHarness'
import backgroundWait from './helpers/backgroundWait'
import testCases from 'privacy-test-pages/adClickFlow/shared/testCases.json'
import { routeFromLocalhost } from './helpers/testPages'

if (testCases.length === 0) {
throw new Error('No test cases found')
Expand Down Expand Up @@ -50,6 +51,8 @@
// Allow to filter to one test case
const itMethod = testCase.only ? test.only : test
itMethod(testCase.name, async ({ context }) => {
// route requests from all pages in this test to our local test server
await routeFromLocalhost(context)
let page = await context.newPage()
for (const step of testCase.steps) {
if (step.action.type === 'navigate') {
Expand All @@ -74,7 +77,7 @@

if (step.expected.requests) {
const resources = await page.evaluate(() => globalThis.resources)
expect(resources.length).toBe(step.expected.requests.length)

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param 

  3) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param, but missing u3 param 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param 

  3) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param, but missing u3 param 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param 

  3) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param, but missing u3 param 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param 

  4) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param, but missing dsl param 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session, variant two 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session, variant two 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session, variant two 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param; u3 param included 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param; dsl param included 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param 

  3) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param, but missing u3 param 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param 

  3) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param, but missing u3 param 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param 

  3) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › y.js heuristic; no ad_domain param, but missing u3 param 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 1/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param 

  4) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › m.js heuristic; no ad_domain param, but missing dsl param 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  1) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session, variant two 
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session, variant two 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38

Check failure on line 80 in integration-test/click-attribution.spec.js

View workflow job for this annotation

GitHub Actions / playwright-tests (playwright-mv3, 2/4)

[chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site 

  2) [chromium] › click-attribution.spec.js:53:9 › Ad click blocking › Single-site, new-tab, session, variant two 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'length')

      78 |                 if (step.expected.requests) {
      79 |                     const resources = await page.evaluate(() => globalThis.resources)
    > 80 |                     expect(resources.length).toBe(step.expected.requests.length)
         |                                      ^
      81 |                     for (const request of step.expected.requests) {
      82 |                         const expectedResource = resources.find(resource => resource.url === request.url)
      83 |                         expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)

        at /home/runner/work/duckduckgo-privacy-extension/duckduckgo-privacy-extension/integration-test/click-attribution.spec.js:80:38
for (const request of step.expected.requests) {
const expectedResource = resources.find(resource => resource.url === request.url)
expect(expectedResource, `${step.name} expects ${request.url} to have be detected in the page`)
Expand Down
7 changes: 6 additions & 1 deletion integration-test/helpers/testPages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ const testPageHosts = new Set([
'privacy-test-pages.site',
'broken.third-party.site',
'good.third-party.site',
'bad.third-party.site'
'bad.third-party.site',
'convert.ad-company.site',
// 'www.search-company.site',
// 'www.ad-company.site', - redirects to these domains via route overriding seem to hang, so this one has to hit the real server
'www.publisher-company.site',
'www.payment-company.site'
])

export const TEST_SERVER_ORIGIN = 'http://127.0.0.1:3000'
Expand Down
Loading