Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web navigation errors to breakage reports #2358

Merged
merged 1 commit into from Nov 22, 2023
Merged

Add web navigation errors to breakage reports #2358

merged 1 commit into from Nov 22, 2023

Conversation

jonathanKingston
Copy link
Collaborator

Reviewer: @sammacbeth

Description:

We're missing some errors that happen at navigation time. See https://app.asana.com/0/inbox/1199237043596759/1205948701794778/1205968619180325/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston jonathanKingston marked this pull request as ready for review November 21, 2023 16:13
@jonathanKingston jonathanKingston merged commit 3fba998 into main Nov 22, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammacbeth sammacbeth sammacbeth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanKingston @sammacbeth