Prevent extension crash when omnibox API is not available. #2377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
Guards our use of
browser.omnibox
so the extension doesn't crash when this API is missing. This is the case in Firefox on Android and for Safari MV3 extensions.I've also moved this code into its own component, as part of ongoing work to clean up
events.js
.Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: