Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list editor with tabs and improved UI #2407

Merged
merged 3 commits into from Jan 9, 2024
Merged

Conversation

tagawa
Copy link
Contributor

@tagawa tagawa commented Jan 4, 2024

Reviewer:
@sammacbeth

CC:
@GuiltyDolphin

Description:

The current list editor is functional, but to make it easier to use should have a better UI.
This PR uses the existing extension styles (in base.css) and replaces the list chooser dropdown with tabs, to save clicks.
See internal task: https://app.asana.com/0/0/1206280121954707/f

Steps to test this PR:

  1. Once built, open list-editor.html
  2. Check that the tabs change the textarea content.
  3. Check that the buttons still work, e.g. remote file is loaded.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@tagawa tagawa requested a review from sammacbeth January 5, 2024 15:10
Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it looks much nicer now.

@sammacbeth sammacbeth merged commit fa8ad58 into main Jan 9, 2024
23 checks passed
@tagawa
Copy link
Contributor Author

tagawa commented Jan 9, 2024

@sammacbeth Great, thank you for both of these reviews/merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants