Fix blocked request filtering in the dev-tools panel UI #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently base.css is clashing with the devtools-panel stylesheet, causing rows for blocked requests to be displayed incorrectly. The workaround for that appears to have prevented the rows from being hidden, when the toggle to show blocked requests is used. Without digging more deeply into it for now, let's just ensure that blocked requests are hidden with a more specific selector.
|
Thanks, I tested by pasting the new CSS into the live extension debugger and it worked! LGTM :) |
GuiltyDolphin
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently base.css is clashing with the devtools-panel stylesheet,
causing rows for blocked requests to be displayed incorrectly. The
workaround for that appears to have prevented the rows from being
hidden, when the toggle to show blocked requests is used. Without
digging more deeply into it for now, let's just ensure that blocked
requests are hidden with a more specific selector.
Reviewer: @GuiltyDolphin
CC: @tagawa, @laghee