Remove build tooling for static declarativeNetRequest rulesets #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anticipating hitting Chrome's limit of 5,000 dynamic declarativeNetRequest rules[1], we begun work[2] to transition tracker blocking to use a static declarativeNetRequest ruleset. That work got put on hold, and since then Google have relaxed the dynamic rule limit to around 30,000[3] (though note that the limits are even more complex now, with a distinction between "safe" vs "unsafe" rules). The new dynamic rule limit should be plenty for our needs in the foreseeable future. Let's remove the code to generate static declarativeNetRequest rulesets at build time. 1 - https://developer.chrome.com/docs/extensions/reference/declarativeNetRequest/#property-MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES 2 - duckduckgo@d3b3827 3 - https://issues.chromium.org/issues/40282671
sammacbeth
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anticipating hitting Chrome's limit of 5,000 dynamic
declarativeNetRequest rules[1], we begun work[2] to transition tracker
blocking to use a static declarativeNetRequest ruleset. That work got
put on hold, and since then Google have relaxed the dynamic rule limit
to around 30,000[3] (though note that the limits are even more complex
now, with a distinction between "safe" vs "unsafe" rules).
The new dynamic rule limit should be plenty for our needs in the
foreseeable future. Let's remove the code to generate static
declarativeNetRequest rulesets at build time.
1 - https://developer.chrome.com/docs/extensions/reference/declarativeNetRequest/#property-MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES
2 - d3b3827
3 - https://issues.chromium.org/issues/40282671
Reviewer: @sammacbeth