Pass ATB param better #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-p
commented
Aug 28, 2018
| @@ -9,9 +9,7 @@ const ATB = require('./atb.es6') | |||
| chrome.runtime.onInstalled.addListener(function (details) { | |||
| if (details.reason.match(/install/)) { | |||
| ATB.updateATBValues() | |||
|
|
|||
| // need to wait a bit for ATB to be set | |||
| setTimeout(() => ATB.openPostInstallPage(), 2000) | |||
There was a problem hiding this comment.
Nice that this timeout could be removed now that we definitely know when ATB param is retrieved.
andrey-p
commented
Aug 28, 2018
| }) | ||
| } | ||
|
|
||
| resolve(tabs.map(tab => tab.url)) |
There was a problem hiding this comment.
I'm just passing the URLs from here, then reading them back from within the ATB module. That way it's easier to add tests.
andrey-p
commented
Aug 28, 2018
| }) | ||
| let getDDGTabUrls = () => { | ||
| // we don't currently support getting ATB from install page on Safari | ||
| return Promise.resolve([]) | ||
| } |
There was a problem hiding this comment.
It shouldn't be too difficult to actually return URLs from here, but I guess it's not a codepath we actually care about if Safari only does gallery installs now.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @jdorweiler
CC: @bsstoner
Description:
This gets the extension to pick up ATB param on install from the query string.
Steps to test this PR:
On FF/Chrome:
v123-4ab.Automated tests:
Reviewer Checklist:
PR Author Checklist: