New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block requests with type "beacon" or "ping" #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; suggested simplification.
…con/ping type to it
…con/ping type to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @MariagraziaAlastra ! This looks great.
At some point we should build some new unit tests for trackers.es6 (and maybe make that isTracker function a little more testable) so that we can better test things like trackersByParentCompany.reason. I don't think here is the place or time to do that though.
Reviewer: @dharb
Description:
Beacon and ping type requests are slipping through currently, because they're not included in the list of resource types we recognize and block.
However, adding "beacon" to the list errors on Chrome, while "ping" doesn't seem to block anything in Firefox.
With this change we'll add either beacon or ping on extension install/update depending on the browser.
Also add "beacon" as a reason for blocking these requests.
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: