This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Seeing I don't have commit bits myself on this repo yet #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have commit bits :-) No idea! ;) hehe Yeah strange that my editor again made fuckup, i fixed it actually but seems it comes back all the time, must switch my IDE... |
|
Oh sorry you are right, for THIS you dont have ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getty was having some problems with a text content based test.
It turns out it was occurring because some files had windows \r line endings in them, and others did not.
Its somewhat a bad idea to have an inconsistent line ending standard for a project, so I removed \r project wide , and added a test to dist.ini to enforce no \r .
And surprise surprise, @Getty's tests now pass =)