This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Rewrite: proxy_set_header gets set in other ways, too. #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy_set_header
doesn't only get set when$uses_echo_module
is true. It also gets set when$self->accept_header
and$is_duckduckgo
are true. So it's important to check if at least one of them is true because only one of them is enough to override all theproxy_set_headers
that were set beforehand.