This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Rewrite: Ignore headers if we have proxy_cache_valid set. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want response headers from the endpoints from interfering with proxy_cache_valid. Using proxy_ignore_headers will fix that. From the proxy_cache_valid documentation: > Parameters of caching can also be set directly in the response header. This has higher priority than setting of caching time using the directive. The “X-Accel-Expires” header field sets caching time of a response in seconds. The zero value disables caching for a response. If the value starts with the @ prefix, it sets an absolute time in seconds since Epoch, up to which the response may be cached. If the header does not include the “X-Accel-Expires” field, parameters of caching may be set in the header fields “Expires” or “Cache-Control”. If the header includes the “Set-Cookie” field, such a response will not be cached. Processing of one or more of these response header fields can be disabled using the proxy_ignore_headers directive.
| @@ -159,7 +159,12 @@ sub _build_nginx_conf { | |||
| $cfg .= "\trewrite ^".$self->path.($self->has_from ? $self->from : "(.*)")." ".$uri_path." break;\n"; | |||
| $cfg .= "\tproxy_pass ".$scheme."://".$host.":".$port."/;\n"; | |||
| $cfg .= "\tproxy_set_header ".$self->proxy_x_forwarded_for.";\n" if $is_duckduckgo; | |||
| $cfg .= "\tproxy_cache_valid ".$self->proxy_cache_valid.";\n" if $self->has_proxy_cache_valid; | |||
|
|
|||
| if($self->proxy_cache_valid) { | |||
There was a problem hiding this comment.
This should call the predicate function via $self->has_proxy_cache_valid.
|
@nilnilnil Ah, you're right. Good catch! Changed it to the predicate function. |
|
👍 thx |
nilnilnil
added a commit
that referenced
this pull request
Aug 21, 2014
Rewrite: Ignore headers if we have proxy_cache_valid set.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want response headers from the endpoints from interfering with proxy_cache_valid. Using proxy_ignore_headers will fix that. We only ignore the headers if we explicitly want to set the caching.
From the proxy_cache_valid documentation:
And from the proxy_ignore_headers documentation:
Here it is caching things that should be cached (see X-Cache-Status header):
Ones that shouldn't be cached still aren't cached like Dictionary/Audio:
