Replace SwiftLintPlugin with SwiftLintTool #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2024
github-actions
bot
added
the
bot: not in app board
github-actions
bot
removed
the
bot: not in app board
ayoy
approved these changes
Apr 17, 2024
DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mallexxx
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Apr 18, 2024
Task/Issue URL: https://app.asana.com/0/1201037661562251/1206803066031565/f apple-toolbox PR: duckduckgo/apple-toolbox#3 iOS PR: duckduckgo/iOS#2710 macOS PR: duckduckgo/macos-browser#2601
mallexxx
added a commit
to duckduckgo/apple-toolbox
that referenced
this pull request
Apr 18, 2024
mallexxx
added a commit
to duckduckgo/apple-toolbox
that referenced
this pull request
Apr 18, 2024
mallexxx
added a commit
to duckduckgo/apple-toolbox
that referenced
this pull request
Apr 18, 2024
samsymons
added a commit
that referenced
this pull request
Apr 20, 2024
# By Daniel Bernal (11) and others # Via Mariusz Śpiewak (3) and others * main: (63 commits) Release 7.115.1-1 (#2770) Fix iOS auto-clearing fails to remove cookies (#2769) Release 7.115.1-0 (#2768) Fix iOS auto-clearing fails to remove cookies (#2767) iOS: VPN screen improvements (#2721) Release 7.116.0-2 (#2763) Remove "Thank You" prompt (#2762) Test to ensure that page refresh doesn't affect url bar focus (#2749) Add support for uploading crash reports to Sentry (#2720) Replace SwiftLintPlugin with SwiftLintTool (#2710) Release 7.116.0-1 (#2761) Remove validator app (#2754) Fix crash when quickly adding/removing tabs in switcher (#2760) Fix settings navigation bar colors after reopening (#2758) Alpha ad-hoc lane (#2492) Keep a weak reference to UserScriptMessageBroker (#2755) Add refresh config cell to top of debug (#2735) VPN: Replace available interfaces in VPN metadata (#2750) Require device auth to be set in order to use Sync (#2722) Add new iOS pixels for measuring navigation (#2730) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/AppDelegate.swift # DuckDuckGo/MainViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
apple-toolbox PR: duckduckgo/apple-toolbox#3
BSK PR: duckduckgo/BrowserServicesKit#774
macOS PR: https://github.com/duckduckgo/macos-browser/pull/2601
Description:
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template