Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS auto-clearing fails to remove cookies #2767

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jotaemepereira
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1207126219690101/f
Tech Design URL:
CC:

Description:
This reverts commit cebfbf5.

Steps to test this PR:

  1. Set auto-clear on, and on exit app
  2. Go to Reddit, login, and do some queries on Google
  3. kill the app, and come back
  4. you shouldn’t be logged it on Reedit, and you shouldn’t see any old queries in Google

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit 685776f into hotfix/7.115.1 Apr 19, 2024
9 of 10 checks passed
@ayoy ayoy deleted the hotifx/ios-incident-20240419 branch April 19, 2024 19:05
samsymons added a commit that referenced this pull request Apr 20, 2024
# By Daniel Bernal (11) and others
# Via Mariusz Śpiewak (3) and others
* main: (63 commits)
  Release 7.115.1-1 (#2770)
  Fix iOS auto-clearing fails to remove cookies (#2769)
  Release 7.115.1-0 (#2768)
  Fix iOS auto-clearing fails to remove cookies (#2767)
  iOS: VPN screen improvements (#2721)
  Release 7.116.0-2 (#2763)
  Remove "Thank You" prompt (#2762)
  Test to ensure that page refresh doesn't affect url bar focus (#2749)
  Add support for uploading crash reports to Sentry (#2720)
  Replace SwiftLintPlugin with SwiftLintTool (#2710)
  Release 7.116.0-1 (#2761)
  Remove validator app (#2754)
  Fix crash when quickly adding/removing tabs in switcher (#2760)
  Fix settings navigation bar colors after reopening (#2758)
  Alpha ad-hoc lane (#2492)
  Keep a weak reference to UserScriptMessageBroker (#2755)
  Add refresh config cell to top of debug (#2735)
  VPN: Replace available interfaces in VPN metadata (#2750)
  Require device auth to be set in order to use Sync (#2722)
  Add new iOS pixels for measuring navigation  (#2730)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo/AppDelegate.swift
#	DuckDuckGo/MainViewController.swift
@dus7 dus7 mentioned this pull request Apr 22, 2024
13 tasks
dus7 pushed a commit that referenced this pull request Apr 22, 2024
@dus7 dus7 restored the hotifx/ios-incident-20240419 branch April 22, 2024 09:36
@dus7 dus7 deleted the hotifx/ios-incident-20240419 branch April 22, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants