Fix Maestro reporting for e2e tests #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
loremattei
removed
the
bot: not in app board
bwaresiak
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
LGTM! One question: looking at Sync e2e I see some tests timing out and still be reported as successful: https://github.com/duckduckgo/iOS/actions/runs/8843360123/job/24284991292 is this expected?
|
@bwaresiak it's definitely not! But on that one we also have to fix the underlying issue with the test, so I'm planning to open a dedicated PR to address all the sync test related issues. |
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
samsymons
added a commit
that referenced
this pull request
May 9, 2024
* main: Upload logs on cancel (#2836) Add bookmarks to top hits suggestions on iOS (#2835) Fix Maestro reporting for e2e tests (#2713) support marketplace kit (#2833) Enable attribution flag (#2825) Release 7.119.0-0 (#2831) Fix subscriptions glitch in Settings (#2828) Delegate SecureVault KeyStore Events in All Scenarios (#2827) Clears subscription cache on restore (#2823)
samsymons
added a commit
that referenced
this pull request
May 10, 2024
# By amddg44 (3) and others # Via GitHub (1) and amddg44 (1) * main: Enable gzip compression for Sync PATCH payloads (#2805) sync error notify (#2822) Wire up VPN error UI (#2826) Mergeback from release/7.119.0 Release 7.119.0-1 (#2840) Add temporary survey to Passwords screen (#2834) Upload logs on cancel (#2836) Add bookmarks to top hits suggestions on iOS (#2835) Fix Maestro reporting for e2e tests (#2713) support marketplace kit (#2833) Enable attribution flag (#2825) Release 7.119.0-0 (#2831) Fix subscriptions glitch in Settings (#2828) Delegate SecureVault KeyStore Events in All Scenarios (#2827) Clears subscription cache on restore (#2823) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
May 13, 2024
* main: (27 commits) Release 7.120.0-0 (#2846) Enable gzip compression for Sync PATCH payloads (#2805) sync error notify (#2822) Wire up VPN error UI (#2826) Mergeback from release/7.119.0 Release 7.119.0-1 (#2840) Add temporary survey to Passwords screen (#2834) Upload logs on cancel (#2836) Add bookmarks to top hits suggestions on iOS (#2835) Fix Maestro reporting for e2e tests (#2713) support marketplace kit (#2833) Enable attribution flag (#2825) Release 7.119.0-0 (#2831) Fix subscriptions glitch in Settings (#2828) Delegate SecureVault KeyStore Events in All Scenarios (#2827) Clears subscription cache on restore (#2823) Enable field validation for Sync payloads (#2807) Fix up address bar spoofing tests to match new behaviours. (#2743) Release 7.118.0-4 (#2821) Settings: onAppear changed to onDisappear (#2817) (#2820) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1207008449808441/f
Tech Design URL:
CC:
Description:
Maestro Cloud Action has an issue where timeouts are reported as success.
At the same time, Maestro Cloud CI seems to have an issue where it gets in a weird state when test flows fail because of a timeout: every subsequent uploads/retries is stuck and ends up with a timeout.
The combination of the two issues makes retries show always as a pass in GH, even if they still fail or not run at all.
Maestro CLI seems to be more reliable and reports the state of the CI correctly. Moreover, it seems to be able to correctly cancel tests that timeout.
This PR replaces Maestro Cloud Action with the CLI.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template