-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up address bar spoofing tests to match new behaviours. #2743
Conversation
Remove 0_all test in favour of running each test individually.
I've run the E2E tests a few times no with no issues discovered so I'm pretty happy this PR should fix the issues we were having before. e.g. https://github.com/duckduckgo/iOS/actions/runs/8781732695/job/24094344902 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
* main: Enable field validation for Sync payloads (#2807) Fix up address bar spoofing tests to match new behaviours. (#2743) Release 7.118.0-4 (#2821) Settings: onAppear changed to onDisappear (#2817) (#2820) Manage Expired Subscription (#2764) Replace deprecated tab preview renderer (#2814) Release 7.118.0-3 (#2819) Update release notes. Settings: onAppear changed to onDisappear (#2817) Release 7.118.0-2 (#2815) Improve VPN underlying error detail (#2813) Break the Subscription module’s dependency on BSK (#2804)
* main: (27 commits) Release 7.120.0-0 (#2846) Enable gzip compression for Sync PATCH payloads (#2805) sync error notify (#2822) Wire up VPN error UI (#2826) Mergeback from release/7.119.0 Release 7.119.0-1 (#2840) Add temporary survey to Passwords screen (#2834) Upload logs on cancel (#2836) Add bookmarks to top hits suggestions on iOS (#2835) Fix Maestro reporting for e2e tests (#2713) support marketplace kit (#2833) Enable attribution flag (#2825) Release 7.119.0-0 (#2831) Fix subscriptions glitch in Settings (#2828) Delegate SecureVault KeyStore Events in All Scenarios (#2827) Clears subscription cache on restore (#2823) Enable field validation for Sync payloads (#2807) Fix up address bar spoofing tests to match new behaviours. (#2743) Release 7.118.0-4 (#2821) Settings: onAppear changed to onDisappear (#2817) (#2820) ...
Task/Issue URL: https://app.asana.com/0/0/1207057471208069/f
Tech Design URL: N/A
Description:
As per Change Security maestro test to use new URL target - some core changes were made in one of the address bar spoofing security tests. In the process, I discovered several of the other security tests had also broken, and that they weren't being run in a workflow.
As such I introduce a few changes:
Steps to test this PR:
maestro test --include-tags "securityTest" ./.maestro
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template