Automatic duckpan app restart on IA update #196
Conversation
…es in the development hierarchy.
Apps can declare _run_app() in their package and use App::DuckPAN::Restart. Changes should be as easy as:
1. use Moo;
with qw(App::DuckPAN::Restart);
2. Rename run() _run_app()
3. sub run {
....
$self->run_restarter(\@Args);
}
|
👍 |
|
Failing tests though. |
| $self->_run_app($args); | ||
| exit 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
comment why this is here -- based on our discussion it's because you want to reap the $app if $fmon fails to fork.
There was a problem hiding this comment.
Exactly. We need to clean up the spawned app before exiting with the second fork. If we want the structure to be the same, we can change the first fork to the latter's.
|
@zachthompson still needs merge conflict resolution |
| } | ||
|
|
||
| # wait for one them to exit. -1 waits for all children | ||
| my $pid = waitpid -1, 0; |
There was a problem hiding this comment.
I think there might be a slight race condition here when outside of an IA directory if the pid for the fmon is reaped first. Let me have a look at it. I test this very condition this morning and it was fine but running it this afternoon for something unrelated triggered it.
|
@zachthompson let me know when you're ready. |
|
@zachthompson are you all set here? |
|
@nilnilnil @russellholt ready |
|
👍 |
Automatic duckpan app restart on IA update
| # ABSTRACT: Automatic restarting of application on file change | ||
|
|
||
| use File::Find::Rule; | ||
| use Filesys::Notify::Simple; |
There was a problem hiding this comment.
@zachthompson These need to be added to the dist.ini please :)
Which issues (if any) does this change solve? (please link them here)
#52
Briefly describe your fix. Are there any important details we should know about?
Alternate strategy to #175 code reloading. Adds the role App::DuckPAN::Restart which restarts the running duckpan application automatically when instant answer code is changed.
Incorporates #190 as well since the current query console does not exit cleanly when killed.