Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Bower Fathead : Adds cover/ directory #852

Merged
merged 3 commits into from Mar 18, 2017

Conversation

adityatandon007
Copy link
Contributor

Description of new Instant Answer, or changes

This PR adds the cover/ directory for Bower fathead

Related Issues and Discussions

Fixes #784

People to notify

@pjhampton

Testing & Review

To be completed by Language Leader (or DDG Staff) when reviewing Pull Request

Pull Request

  • Title follows correct format (Specifies Instant Answer + Purpose)
  • Description contains a valid Instant Answer Page Link (e.g. https://duck.co/ia/view/my_ia)

Instant Answer Page (for new Instant Answers)

  • Instant Answer page is correctly filled out and contains:
    • One topic for the Search Space Language (Java, Python, Scala, Ruby, etc.)
    • One topic from: Reference, Help, Libraries, Tools
      • Documentation Fatheads are considered "Reference"
    • Description, Data source, and 2+ example queries
    • Perl Module (e.g. "DDG::Fathead::PerlDoc" -- we only need a name, not an actual file)
    • Source Name (for "More at <source_name>" link)
    • Source Domain (must contain http:// or https:// -- can be the same as Data Source)
    • Source Info (used as Subtitle for each Article -- usually matches the IA Name)
    • 'Skip Abstract' is checked off
    • Source ID (ping @moollaza to assign one, once Fathead is ready for Beta deploy)

Code

  • Uniformly indented, well commented
  • Fetch.sh and Parse.sh run without errors
  • Output contains no blank lines, or multi-line entries
  • Fathead Tests are passing (run $ duckpan test <fathead_id>)
    • Tester should report any failures

Pull Request Review Guidelines: https://docs.duckduckhack.com/programming-mission/pr-review.html


Instant Answer Page: https://duck.co/ia/view/bower

@daxtheduck
Copy link

daxtheduck commented Mar 2, 2017

Bower CLI

Description: Web sites are made of lots of things — frameworks, libraries, assets, and utilities. Bower manages all these things for you.

Example Query: bower help

Tab Name: About

Source: https://bower.io/docs/api/

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page


This is an automated message which will be updated as changes are made to the IA page

@daxtheduck daxtheduck deployed to beta.duckduckgo.com March 2, 2017 21:44 Active
@daxtheduck daxtheduck deployed to beta.duckduckgo.com March 2, 2017 22:16 Active
version A <section class="prog__container"><p>Run this in a package directory to bump the version and write the new data back to the bower.json file.\n\nThe newversion argument should be a valid semver string, or a valid second argument to semver.inc (one of "build", "patch", "minor", or "major"). In the second case, the existing version will be incremented by 1 in the specified field.\n\nIf run in a git repo, it will also create a version commit and tag, and fail if the repo is not clean.</p><pre><code>$ bower version [<newversion> | major | minor | patch]</code></pre></section> https://bower.io/docs/api/#version
version command R version
force A <section class="prog__container"><p>Makes various commands more forceful\n\n- `bower install --force` re-installs all installed components. It also forces installation even when there are non-bower directories with the same name in the components directory. Adding `--force` also bypasses the cache, and writes to the cache anyway.\n- `bower uninstall <package> --force` continues uninstallation even after a dependency conflict\n- `bower register <package> --force` bypasses confirmation. Login is still needed.</p><pre><code>-f, --force</code></pre></section> https://bower.io/docs/api/#force
force A <section class="prog__container"><p>Makes various commands more forceful\n\n- `bower install --force` re-installs all installed components. It also forces installation even when there are non-bower directories with the same name in the components directory. Adding `--force` also bypasses the cache, and writes to the cache anyway.\n- `bower uninstall <package> --force` continues uninstallation even after a dependency conflict\n- `bower register <package> --force` and `bower unregister <package> --force` bypasses confirmation. Login is still needed.</p><pre><code>-f, --force</code></pre></section> https://bower.io/docs/api/#force
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes because of a change in the source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no source is same I just ran the parse file and got this as output, the only missing thing was the unregister command in previous version of output.txt

@daxtheduck daxtheduck deployed to beta.duckduckgo.com March 3, 2017 12:15 Active
Copy link
Contributor

@pjhampton pjhampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seeking clarification on the changes in output.txt

@pjhampton pjhampton merged commit d1d9444 into duckduckgo:master Mar 18, 2017
@pjhampton
Copy link
Contributor

Thanks!! LGTM 👍

💛 💙 ❤️ 💜 💚

@adityatandon007 adityatandon007 deleted the adityatandon/bower branch March 20, 2017 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants