First Goodie hack #1235

abhijainn27 · 2015-07-05T09:12:44Z

Goodie Pull Request Template

Using this template will help us better understand your Instant Answer and assist you when necessary. Simply copy and paste the markdown below into the description of your GitHub pull request and complete as appropriate.

What does your Instant Answer do?
It prints my github username and tell that am awesome and completed the goodie hack.

What problem does your Instant Answer solve (Why is it better than organic links)?
It helps to find me among all other guthub users

What is the data source for your Instant Answer? (Provide a link if possible)
https://duck.co/duckduckhack/goodie_quickstart

Why did you choose this data source?
Because it is my first goodie hack

Are there any other alternative (better) data sources?

What are some example queries that trigger this Instant Answer?
duckduckhack abhijainn27

Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)
github users

Is this Instant Answer connected to a DuckDuckHack Instant Answer idea?

Which existing Instant Answers will this one supercede/overlap with?
None

Are you having any problems? Do you need our help with anything?
No

Where did you hear about DuckDuckHack? (For first time contributors)
FSMK

What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)

Checklist

Please place an 'X' where appropriate.

- [] Added metadata and attribution information (https://duck.co/duckduckhack/metadata)
- [x] Wrote test file and added to t/ directory (https://duck.co/duckduckhack/goodie_tests)
- [] Verified that instant answer adheres to design guidelines (https://duck.co/duckduckhack/design_styleguide)
- [] Verified that instant answer adheres to code styleguide (https://duck.co/duckduckhack/code_styleguide)
- [] Tested cross-browser compatibility

    Please let us know which browsers/devices you've tested on:
    - Windows 8
        - [] Google Chrome
        - [] Firefox
        - [] Opera
        - [] IE 10

    - Windows 7
        - [] Google Chrome
        - [] Firefox
        - [] Opera
        - [] IE 8
        - [] IE 9
        - [] IE 10

    - Windows XP
        - [] IE 7
        - [] IE 8

    - Mac OSX
        - [] Google Chrome
        - [] Firefox
        - [] Opera
        - [] Safari

    - iOS (iPhone)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - iOS (iPad)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - Android
        - [] Firefox
        - [] Native Browser
        - [] Google Chrome
        - [] Opera

    - Linux (Ubuntu)
        - [x] Firefox

MariagraziaAlastra · 2015-07-05T09:39:24Z

lib/DDG/Goodie/IsAwesome/abhijainn27.pm

+# Metadata.  See https://duck.co/duckduckhack/metadata for help in filling out this section.
+name "IsAwesome abhijainn27";
+description "Succinct explanation of what this instant answer does";
+primary_example_queries "first example query", "second example query";


@abhijainn27 Could you change this to be the actual query the goodie will trigger with? In this case that would be "duckduckhack abhijainn27". Thanks!

MariagraziaAlastra · 2015-07-05T09:43:10Z

@abhijainn27 Thanks for this! I've added a few comments inline, just minor things. Nice work!

abhijainn27 · 2015-07-06T06:07:57Z

Hey @MariagraziaAlastra I have made the above changes.. Should i send a new pull request ?

MrChrisW · 2015-07-06T09:38:36Z

@abhijainn27 Provided you push to your master branch, changes you make will be added to this PR.

MrChrisW · 2015-07-06T09:38:59Z

lib/DDG/Goodie/IsAwesome/abhijainn27.pm

+# Metadata.  See https://duck.co/duckduckhack/metadata for help in filling out this section.
+name "IsAwesome abhijainn27";
+description "Succinct explanation of what this instant answer does";
+primary_example_queries "duckduckhack abhijainn27";secondary_example_queries "optional -- demonstrate any additional triggers";


You can remove secondary_example_queries "optional -- demonstrate any additional triggers";

abhijainn27 · 2015-07-07T18:43:06Z

Hey @MrChrisW I removed the secondary query and comment lines. Hope this works fine now. :)

MrChrisW · 2015-07-08T09:07:37Z

lib/DDG/Goodie/IsAwesome/abhijainn27.pm

+
+	return unless $_; # Guard against "no answer"
+
+	return $_;


These two return statements are not needed. They'll never be reached as there's a return on line 24

abhijainn27 · 2015-07-08T13:16:53Z

Hey @MrChrisW I made the above changes.

javathunderman · 2015-07-09T13:21:02Z

lib/DDG/Goodie/IsAwesome/abhijainn27.pm

@@ -0,0 +1,28 @@
+package DDG::Goodie::IsAwesome::abhijainn27;
+


Please add an abstract (something like https://github.com/duckduckgo/zeroclickinfo-goodies/blob/master/lib/DDG/Goodie/IsAwesome/javathunderman.pm#L2)

javathunderman · 2015-07-09T13:21:56Z

Hey @abhijainn27, I left a line note for you. Please fix this and it should be ready to merge.

cc @MrChrisW

abhijainn27 · 2015-07-10T07:18:55Z

Hey @javathunderman I added the abstract.

javathunderman · 2015-07-10T12:00:02Z

@MrChrisW This LGTM...I suggest you give a final review.

MrChrisW · 2015-07-10T12:59:13Z

lib/DDG/Goodie/IsAwesome/abhijainn27.pm

+name "IsAwesome abhijainn27";
+description "My First Goodie Hack !! ";
+primary_example_queries "duckduckhack abhijainn27";
+


@abhijainn27 One last thing, please add

category "special"; topics "special_interest", "geek";

Like this

abhijainn27 · 2015-07-10T15:32:05Z

Done :)

MrChrisW · 2015-07-14T10:31:35Z

lib/DDG/Goodie/IsAwesome/abhijainn27.pm

+package DDG::Goodie::IsAwesome::abhijainn27;
+# ABSTRACT: abhijainn27 first Goodie Hack !!
+# CATEGORY "DuckDuckHack Goodie";
+# TOPICS "Web Development", "geek";


@abhijainn27 Sorry for the delay.

You'll need to add these on line 14 exactly how they're in the comment, these are set meta types

Line 14/15

category "special"; topics "special_interest", "geek";

GuiltyDolphin · 2016-02-15T20:08:06Z

This is really old... I'll close this for now.

@abhijainn27 If you want to finish this, just let us know.

First Goodie hack

e6827f3

MariagraziaAlastra added New Instant Answer First Goodie! labels Jul 5, 2015

MariagraziaAlastra reviewed Jul 5, 2015
View reviewed changes

Made small changes

ee79586

MrChrisW reviewed Jul 6, 2015
View reviewed changes

moollaza self-assigned this Jul 6, 2015

Removed Comment lines

5c83fb0

MrChrisW reviewed Jul 8, 2015
View reviewed changes

Added Description and attributes

7f8c7ac

javathunderman reviewed Jul 9, 2015
View reviewed changes

Added Abstract

a6cfe3f

MrChrisW reviewed Jul 10, 2015
View reviewed changes

Made last few changes

0035b99

MrChrisW reviewed Jul 14, 2015
View reviewed changes

moollaza assigned MrChrisW and unassigned moollaza Jul 23, 2015

GuiltyDolphin closed this Feb 15, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First Goodie hack #1235

First Goodie hack #1235

abhijainn27 commented Jul 5, 2015

MariagraziaAlastra Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

abhijainn27 commented Jul 6, 2015

MrChrisW commented Jul 6, 2015

MrChrisW Jul 6, 2015

abhijainn27 commented Jul 7, 2015

MrChrisW Jul 8, 2015

abhijainn27 commented Jul 8, 2015

javathunderman Jul 9, 2015

javathunderman commented Jul 9, 2015

abhijainn27 commented Jul 10, 2015

javathunderman commented Jul 10, 2015

MrChrisW Jul 10, 2015

abhijainn27 commented Jul 10, 2015

MrChrisW Jul 14, 2015

GuiltyDolphin commented Feb 15, 2016

		@@ -0,0 +1,28 @@
		package DDG::Goodie::IsAwesome::abhijainn27;

First Goodie hack #1235

First Goodie hack #1235

Conversation

abhijainn27 commented Jul 5, 2015

Goodie Pull Request Template

Checklist

MariagraziaAlastra Jul 5, 2015

Choose a reason for hiding this comment

MariagraziaAlastra commented Jul 5, 2015

abhijainn27 commented Jul 6, 2015

MrChrisW commented Jul 6, 2015

MrChrisW Jul 6, 2015

Choose a reason for hiding this comment

abhijainn27 commented Jul 7, 2015

MrChrisW Jul 8, 2015

Choose a reason for hiding this comment

abhijainn27 commented Jul 8, 2015

javathunderman Jul 9, 2015

Choose a reason for hiding this comment

javathunderman commented Jul 9, 2015

abhijainn27 commented Jul 10, 2015

javathunderman commented Jul 10, 2015

MrChrisW Jul 10, 2015

Choose a reason for hiding this comment

abhijainn27 commented Jul 10, 2015

MrChrisW Jul 14, 2015

Choose a reason for hiding this comment

GuiltyDolphin commented Feb 15, 2016