Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Conversions: Fix #3534 #3543

Merged
merged 2 commits into from
Aug 22, 2016
Merged

Conversions: Fix #3534 #3543

merged 2 commits into from
Aug 22, 2016

Conversation

holtjohnson
Copy link
Contributor

@holtjohnson holtjohnson commented Aug 19, 2016

What does your Pull Request do (check all that apply)?

Choose the most relevant items and use the following title template to name
your Pull Request.

  • New Instant Answer
    • Cheat Sheets: New {Cheat Sheet Name} Cheat Sheet
    • Other: New {IA Name} Instant Answer
  • Improvement
    • Bug fix: Conversions: Fix #3534
    • Enhancement: {IA Name}: {Description of Improvements}
  • Non–Instant Answer
    • Other (Role, Template, Test, Documentation, etc.): {GoodieRole/Templates/Tests/Docs}: {Short Description}
Description of changes

I added some more metric measurements and sorted them by size.

Which issues (if any) does this fix?

Fixes #3534 - Add additional metric measurements.

People to notify (@mention interested parties)

@mintsoft
@Zekario


Instant Answer Page: https://duck.co/ia/view/conversions

Maintainer: @mintsoft

@daxtheduck
Copy link

@holtjohnson Hey!

Thanks for taking the time to contribute! We really appreciate it.

We work closely with every contributor to make Instant Answers the best they can be, so we appreciate your patience as we look over your code. From here, the process usually goes like this:

  1. Pull Request is reviewed by the DuckDuckGo staff and community
  2. Staff and community will leave feedback with any necessary updates to the function or design.
  3. Once you've made any necessary corrections, then your Instant Answer will be merged and deployed live on DuckDuckGo!

If you have any questions along the way, feel free to ask them here. Our staff and community are also available on Slack to answer any questions you may have. If you'd like to join us there please head to https://quackslack.herokuapp.com/ to get an invite.

More Info: http://docs.duckduckhack.com/submitting/submitting-overview.html

Thanks!

@daxtheduck
Copy link

daxtheduck commented Aug 19, 2016

Conversions

Description: convert between various units of measurement

Example Query: [convert 5 oz to grams](https://beta.duckduckgo.com/?q=convert 5 oz to grams), [5 ounces to g](https://beta.duckduckgo.com/?q=5 ounces to g), [0.5 nautical miles in km](https://beta.duckduckgo.com/?q=0.5 nautical miles in km)

Tab Name: Answer

Source:

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page


This is an automated message which will be updated as changes are made to the IA page

@mintsoft mintsoft self-assigned this Aug 21, 2016
- dal
factor: 0.1
type: volume
unit: decaitre
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the SI name of this unit is decalitre and the plural decalitres ?

@mintsoft
Copy link
Collaborator

Thanks for doing this @holtjohnson It should definitely plug some of the query holes. I've just checked over it and it all looks OK with 1 exception; I think there's a typo in the decalitre name. Other than that it looks ready to go

@holtjohnson
Copy link
Contributor Author

You're correct. I fixed the typo @mintsoft.

@mintsoft
Copy link
Collaborator

Awesome. Muchos gracias amigo

@mintsoft mintsoft merged commit 94a3840 into duckduckgo:master Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversions: Can't convert various metric measurements
3 participants