-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Minecraft: British spelling of colour #4272
Conversation
MinecraftDescription: Minecraft crafting recipes. Example Query: cake minecraft, how do i craft a cake in minecraft Tab Name: Answer Source: These are the important fields from the IA page. Please check these for errors or missing information and update the IA page This is an automated message which will be updated as changes are made to the IA page |
t/Minecraft.t
Outdated
@@ -140,7 +165,7 @@ ddg_goodie_test( | |||
sub make_structured_answer { | |||
my ($name, $ingredients, $description, $image ) = @_; | |||
my %recipe = ( | |||
name => $name, | |||
name => $name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the hard-tab here? it should be 4 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mintsoft got it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirkins, there's still a tab here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description of new Instant Answer, or changes
This matches British spelling of colour for minecraft guide.
Will re-base with #4271 if it's finished and pulled before this one.
Related Issues and Discussions
People to notify
Testing & Review
To be completed by Community Leader (or DDG Staff) when reviewing Pull Request
Pull Request
Instant Answer Page (for new Instant Answers)
Code
$ duckpan test <goodie_id>
)Ready to merge?
Pull Request Review Guidelines: https://docs.duckduckhack.com/programming-mission/pr-review.html
Instant Answer Page: https://duck.co/ia/view/minecraft