Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Minecraft: British spelling of colour #4272

Merged
merged 3 commits into from
Jun 14, 2017

Conversation

kirkins
Copy link
Contributor

@kirkins kirkins commented Jun 10, 2017

Description of new Instant Answer, or changes

This matches British spelling of colour for minecraft guide.

Will re-base with #4271 if it's finished and pulled before this one.

Related Issues and Discussions

People to notify

Testing & Review

To be completed by Community Leader (or DDG Staff) when reviewing Pull Request

Pull Request

  • Title follows correct format (Specifies Instant Answer + Purpose)
  • Description contains a valid Instant Answer Page Link (e.g. https://duck.co/ia/view/my_ia)

Instant Answer Page (for new Instant Answers)

  • Instant Answer page is correctly filled out and contains:
    • The Title is appropriately named and formatted
    • The IA topics are present and appropriate
    • The Description is clear and coherent
    • Source Name exists if applicable
    • All Example Queries trigger on Beta

Code

  • Adheres to the DuckDuckGo Style Guide
  • Behaviour is appropriately tested. If improvement, tests are adequately extended.
  • There is no unnecessary files in place (such as editor config files)
  • There is no API keys / secrets present
  • Tests are passing (run $ duckpan test <goodie_id>)
    • Tester should report any failures

Ready to merge?

  • Has this IA been deployed to and tested on beta.duckduckgo.com?
  • For larger commits, has this been approved be more than one community member?
  • The number of reviews is appropriate for this type of PR
  • The commit message is clear, coherent and fitting

Pull Request Review Guidelines: https://docs.duckduckhack.com/programming-mission/pr-review.html


Instant Answer Page: https://duck.co/ia/view/minecraft

@daxtheduck
Copy link

daxtheduck commented Jun 10, 2017

Minecraft

Description: Minecraft crafting recipes.

Example Query: cake minecraft, how do i craft a cake in minecraft

Tab Name: Answer

Source:

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page


This is an automated message which will be updated as changes are made to the IA page

@kirkins kirkins changed the title British minecraft British spelling of colour for minecraft Jun 10, 2017
t/Minecraft.t Outdated
@@ -140,7 +165,7 @@ ddg_goodie_test(
sub make_structured_answer {
my ($name, $ingredients, $description, $image ) = @_;
my %recipe = (
name => $name,
name => $name,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the hard-tab here? it should be 4 spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mintsoft got it 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirkins, there's still a tab here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mintsoft no not really. I can see why you'd think that from the above but try highlighting the white space on this page.

@mintsoft mintsoft changed the title British spelling of colour for minecraft Minecraft: British spelling of colour Jun 11, 2017
Copy link
Collaborator

@engvik engvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mintsoft mintsoft merged commit dc88760 into duckduckgo:master Jun 14, 2017
@kirkins kirkins deleted the british_minecraft branch June 14, 2017 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants