This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Add favicons to lastfm and rubygems instant search #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to the codebase.
|
@macobo thanks a lot for this PR, we really appreciate it. I'm going to give it a quick test and then it should be good to merge. |
|
and congrats on your first PR 🍰, I look forward to merging many more ;) |
|
It looks like RubyGems is actually working on the live site right now, but being explicit won't hurt. LGTM 👍 |
moollaza
added a commit
that referenced
this pull request
Oct 30, 2014
Add favicons to lastfm and rubygems instant search
|
@macobo Thank you! |
This was referenced Oct 31, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with issues #1200 and #1204.
cc: @jagtalon (author of the issues).
First PR for ddg \o/