This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Currency: Display tile view if only the currency is given, i.e., "usd" #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two horizontal lines above are slightly longer.
"usd to usd" still won't work, but for queries such as "usd" or "10 usd", we have to convert it to _something_. The solution before was to default to either USD or EUR. For example, "10 cad" will be equivalent to "10 cad to usd".
For example, "usd" or "1 usd" should show the tile view, but "10 usd" shouldn't.
|
Closing this for now because there is an internal change that needs to be added first, i.e., the iconfont for the tile. |
|
Reopening because the iconfont that we need has been added! |
|
CC @moollaza |
|
Looks good on desktop and mobile 👍 |
moollaza
added a commit
that referenced
this pull request
Nov 17, 2014
Currency: Display tile view if only the currency is given, i.e., "usd"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests:
http://www.browserstack.com/screenshots/6e395e50a96c32d3440c0d2883f31cf9f8198f2f
http://www.browserstack.com/screenshots/d7d3d598b9fc9b8d8aeb2f6c1469b37fd2ef0646
http://www.browserstack.com/screenshots/54a94a6d36dde26e467157b3adcaa6a5f62b52d8
http://www.browserstack.com/screenshots/3e359c0a54f09d3d54762a0398e56a2c440ed4ca