This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Rainfall update #1229
Merged
Rainfall update #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if($countryCode) { | ||
| $countryName = code2country(country2code($countryName, LOCALE_CODE_ALPHA_2), LOCALE_CODE_ALPHA_2); | ||
| } else { | ||
| $countryName = code2country(country2code(code2country($countryName, LOCALE_CODE_ALPHA_3), LOCALE_CODE_ALPHA_2), LOCALE_CODE_ALPHA_2); |
There was a problem hiding this comment.
This line is ugly 😒 but is required as the Locale::Country::rename_country method only works for code2country LOCALE_CODE_ALPHA_2
|
Should probably fix this #1219 also... |
|
Thanks! Testing it out. |
|
@jagtalon Let me know if I need to switch it to the base template.... |
|
@chrisjwilsoncom This looks good. Possible changes in the future:
return {
title: ...
subtitle: ...
};It should fix that whitespace at the top:
Take a look at expatistan.js as an example.
|
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new triggers:
Add support for Alpha-3 country codes: